Do not enable TLS certificate revocation checks by default #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bioball
force-pushed
the
soft-fail-ocsp
branch
3 times, most recently
from
5c9d43c to
c8dc5d8
Compare
This addresses an issue where network requests may fail if cert revocation checks error, which may occur due to availaibility issues, or due to lack of internet access. This also changes the built-in certs to be loaded from resources, which lets us enable soft-fail when CA certs come from Pkl's built-in certs.
stackoverflow
approved these changes
Jun 27, 2024
holzensp
approved these changes
Jun 27, 2024
bioball
changed the title
bioball
commented
Jun 27, 2024
| var pkixParameters = new PKIXBuilderParameters(trustAnchors, new X509CertSelector()); | ||
| // equivalent of "com.sun.net.ssl.checkRevocation=true" | ||
| pkixParameters.setRevocationEnabled(true); | ||
| pkixParameters.addCertPathChecker(revocationChecker); |
There was a problem hiding this comment.
Using PKIXBuilderParameters results in revocation checking being enabled by default when testing this locally.
So, I changed this to using KeyStore instead, which results in the Java client looking for property com.sun.net.ssl.checkRevocation before it does any revocation checks.
bioball
added a commit
that referenced
this pull request
Jun 28, 2024
This addresses an issue where network requests may fail if cert revocation checks error, which may occur due to availability issues, or due to lack of internet access. Revocation checking can still be enabled by setting JVM property com.sun.net.ssl.checkRevocation if on the JVM. Also: * Load built-in certs from resources, and move them to pkl-commons-cli * Fix an issue where HttpInitException is not caught when loading a module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where network requests may fail if cert revocation checks error, which may occur due to availability issues, or due to lack of internet access.
This changes the HTTP client to not check revocation on TLS certificates by default.
Users of the Java client can enable this by setting Java property
com.sun.net.ssl.checkRevocationtotrue.Users of the native executables will not perform revocation checks.