Mark protobuf module as deprecated#1778
Open
bioball wants to merge 2 commits into
Open
Conversation
This moves the protobuf module from experimental to deprecated
HT154
approved these changes
Jul 15, 2026
HT154
left a comment
Contributor
There was a problem hiding this comment.
Do we also want to remove textproto from the pkl eval --format CLI help?
Contributor
|
Does it really make sense to only deprecate it instead of just removing it? It is marked as experimental and is probably not used often, if ever. I'm not sure you really want to take on the burden of going through a deprecation cycle. |
Member
Author
|
@StefMa good thought, although, we don't ever straight up APIs from the stdlib; they always go through a deprecation cycle first. We'll likely get rid of this entirely in Pkl 0.34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the protobuf module from experimental to deprecated
Rationale: