Skip to content

Mark protobuf module as deprecated#1778

Open
bioball wants to merge 2 commits into
apple:mainfrom
bioball:deprecate-protobuf
Open

Mark protobuf module as deprecated#1778
bioball wants to merge 2 commits into
apple:mainfrom
bioball:deprecate-protobuf

Conversation

@bioball

@bioball bioball commented Jul 15, 2026

Copy link
Copy Markdown
Member

This moves the protobuf module from experimental to deprecated

Rationale:

  • This is very seldom used, if used at all
  • Not fully fleshed out (this really should be paired with a protoc-gen-pkl, which doesn't exist)
  • There is a ProtoJSON wire format that we can already render to

This moves the protobuf module from experimental to deprecated

@HT154 HT154 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to remove textproto from the pkl eval --format CLI help?

@StefMa

StefMa commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Does it really make sense to only deprecate it instead of just removing it? It is marked as experimental and is probably not used often, if ever. I'm not sure you really want to take on the burden of going through a deprecation cycle.

@bioball

bioball commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@StefMa good thought, although, we don't ever straight up APIs from the stdlib; they always go through a deprecation cycle first.

We'll likely get rid of this entirely in Pkl 0.34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants