Restore compatibility with Xcode 14.3/macOS SDK 13.4 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superb @vzsg! Could you please confirm the Xcode version that you were able to test this with? |
I'm using Xcode 14.3.1 (14E300c). |
alejandro-isaza
approved these changes
Jul 12, 2023
This was referenced Jul 12, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three strategically placed
#if canImportstatements, that would allow anyone not on beta macOS and beta Xcode versions to build ml-stable-diffusion 1.0.0 — with the multilingual text encoding disabled.If it was accepted, it would definitely help working with the library during the Xcode 15 transitionary period.
#########