Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brief instructions to download weights from the Hub #10

Merged
merged 9 commits into from
Dec 22, 2022

Conversation

pcuenca
Copy link
Contributor

@pcuenca pcuenca commented Dec 2, 2022

This should be convenient and time-saving for many users.

This should be convenient and time-saving for many users.
@pcuenca
Copy link
Contributor Author

pcuenca commented Dec 20, 2022

  • I agree to the terms outlined in CONTRIBUTING.md

Copy link
Collaborator

@atiorh atiorh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pcuenca! Added three comments that you can hopefully address. Once you rebase on main, could you please place this README section below the System Requirements section?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pcuenca
Copy link
Contributor Author

pcuenca commented Dec 21, 2022

Done, let me know how it looks, happy to apply any other changes we need :)

Copy link
Collaborator

@atiorh atiorh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this @pcuenca, we are almost there 🙏

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@godly-devotion
Copy link
Contributor

godly-devotion commented Dec 21, 2022

I'm not sure if this is worth including but I've converted and uploaded a few popular Stable Diffusion based models here as well https://huggingface.co/godly-devotion

@pcuenca
Copy link
Contributor Author

pcuenca commented Dec 22, 2022

Thanks, @atiorh, all your suggestions make perfect sense to me.

@atiorh atiorh merged commit 877ccb9 into apple:main Dec 22, 2022
@pcuenca pcuenca deleted the hub-weights branch December 23, 2022 21:07
takeyat pushed a commit to takeyat/ml-stable-diffusion that referenced this pull request Dec 25, 2022
* commit 'e07c4d00c387840f70fa3701fb3a51c2a32f37b8':
  Move guidanceScale as generation parameter (apple#46)
  Add brief instructions to download weights from the Hub (apple#10)
  Adds Negative Prompts (apple#61)
  Changed seed type into UInt32 (apple#47)
  fixes apple#77
  Update README.md (apple#66)
  Add Filename Character Limit (apple#19)
  Implement DPM-Solver++ scheduler (apple#59)
  Fix typos: Successfully facilitate getting pipeline overridden (apple#30)
  Undefined name: from typing import List (apple#31)
  Add Availability Annotations (apple#18)
  README improvements and reduceMemory option in Swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants