Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the hardcoded runTests timeouts as parameters in test files #8765

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

sfc-gh-clin
Copy link
Collaborator

@sfc-gh-clin sfc-gh-clin commented Nov 10, 2022

Added three parameters in tests files

[configuration]
longRunningTest =
simulationNormalRunTestsTimeoutSeconds = 
simulationBuggifyRunTestsTimeoutSeconds =

Something like the above,
default is the same as the current hardcoded values.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

…ningTest para to disable Simulation timeout restriction
@sfc-gh-clin sfc-gh-clin self-assigned this Nov 10, 2022
defaultTenant,
tenantsToCreate,
rebooting);
wait(testConfig.longRunningTest ? runTestsF
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the idea is that longRunningTests don't have a timeout at all? And we rely on joshua to kill them?

Copy link
Collaborator Author

@sfc-gh-clin sfc-gh-clin Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the test file already has test durations for tests it's running.
The basic idea is the test itself will run as the given time duration and let Joshua control the overall timeout.
The longRunningTest = true is used to lift the timeout control.

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@sfc-gh-clin sfc-gh-clin merged commit 9a64328 into apple:main Nov 10, 2022
@sfc-gh-clin sfc-gh-clin deleted the make-the-timeout-a-knob branch November 10, 2022 00:57
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 517b44e
  • Duration 1:57:31
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants