-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the hardcoded runTests timeouts as parameters in test files #8765
Conversation
…ningTest para to disable Simulation timeout restriction
defaultTenant, | ||
tenantsToCreate, | ||
rebooting); | ||
wait(testConfig.longRunningTest ? runTestsF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the idea is that longRunningTests don't have a timeout at all? And we rely on joshua to kill them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the test file already has test durations for tests it's running.
The basic idea is the test itself will run as the given time duration and let Joshua control the overall timeout.
The longRunningTest = true
is used to lift the timeout control.
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Added three parameters in tests files
Something like the above,
default is the same as the current hardcoded values.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)