Skip to content

fix "Unknown error" when configuring regions (#11806) [release-7.4] #12314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarkSh1
Copy link
Contributor

@MarkSh1 MarkSh1 commented Aug 20, 2025

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

* fix "Unknown error" when  configuring regions

* fix "Unknown error" when configuring regions
@MarkSh1 MarkSh1 requested a review from spraza as a code owner August 20, 2025 11:27
@spraza spraza closed this Aug 20, 2025
@spraza spraza reopened this Aug 20, 2025
@spraza
Copy link
Collaborator

spraza commented Aug 20, 2025

Looks good. Let me run CI. If it passes, I will accept and merge. Thanks for backporting this fix to 7.4.

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 7a61cfe
  • Duration 0:48:26
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 7a61cfe
  • Duration 1:16:07
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 7a61cfe
  • Duration 1:21:36
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 7a61cfe
  • Duration 1:24:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@spraza
Copy link
Collaborator

spraza commented Aug 20, 2025

The arm failure is when we run ctest:

         45 - fdb_c_api_test_CApiCorrectnessCallbacksOnExtThr (Failed)

I don't think it's related to this change but I can double check.

@jzhou77 jzhou77 changed the title fix "Unknown error" when configuring regions (#11806) fix "Unknown error" when configuring regions (#11806) [release-7.4] Aug 20, 2025
@spraza spraza merged commit 2306086 into apple:release-7.4 Aug 21, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants