Improper use of onReadable in HTTPServer within fdbrpc

I see in the documentation for conn->onReadable() that a prior conn->read() which returns 0 is required before calling conn->onReadable(). Does this imply that the HTTP server implementation in fdbrpc is incorrect?

foundationdb/flow/include/flow/IConnection.h

Lines 58 to 60 in e130005

    
           // Precondition: read() has been called and last returned 0 
        
           // returns when read() can read at least one byte (or may throw an error if the connection dies) 
        
           virtual Future<Void> onReadable() = 0;

There is no conn->read() call before conn->onReadable in the connectionHandler implementation.

foundationdb/fdbrpc/HTTPServer.actor.cpp

Lines 89 to 91 in e130005

    
           wait(readPrevRequest); 
        
           wait(delay(0)); 
        
           wait(conn->onReadable());

Fix IConnection::onReadable() precondition violation in HTTPServer (a…

Fix misleading onReadable() precondition in IConnection (apple#12401)

Fix misleading onReadable() precondition in IConnection (#12401) (#12810

Navigation Menu

Repository navigation

Improper use of onReadable in HTTPServer within fdbrpc #12401

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Precondition: read() has been called and last returned 0
	// returns when read() can read at least one byte (or may throw an error if the connection dies)
	virtual Future<Void> onReadable() = 0;

	wait(readPrevRequest);
	wait(delay(0));
	wait(conn->onReadable());

Improper use of onReadable in HTTPServer within fdbrpc #12401

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions