Update minimum required CMake versions for compatibility with CMake 4.x #2597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This helped me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the minimum required CMake versions in the build scripts to make sure coremltools can be built with newer versions of CMake (like 4.x).
Details
When trying to build coremltools from source with CMake 4.x, I ran into errors because the old minimum version requirements are no longer supported. Updating these to 3.5 and 3.10 fixes the issue and lets the build complete successfully.
cmake_minimum_requiredto 3.10.0 in CMakeLists.txtcmake_minimum_requiredto 3.5.0 in CMakeLists.txtThis should help anyone using a modern CMake version build coremltools without running into compatibility errors. No changes to the actual code—just a small tweak to the build setup.