Skip to content

Fix a bug when destructing coreml model #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix a bug when destructing coreml model #1515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions coremltools/models/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,8 @@ def __del__(self):
# Cleanup temporary package upon destruction
if hasattr(self, 'is_package') and self.is_package \
and hasattr(self, 'is_temp_package') and self.is_temp_package:
if _shutil is None:
import shutil as _shutil
_shutil.rmtree(self.package_path)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the issue in the line _shutil.rmtree(self.package_path) ? if the self.package_path is None or empty and hence there is nothing to remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because the package itself (shutil) is destructed before this del function is called


@property
Expand Down