Skip to content

Add torch AdaptiveAvgPool2d test. #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2022
Merged

Add torch AdaptiveAvgPool2d test. #1502

merged 2 commits into from
Jun 13, 2022

Conversation

fukatani
Copy link
Contributor

test_adaptive_avg_pool2d is missing.

@TobyRoseman
Copy link
Collaborator

Thanks for the test. Changes look good to me.

CI Run: https://gitlab.com/zach_nation/coremltools/-/pipelines/555525076

ArjunSharda
ArjunSharda suggested changes Jun 12, 2022
View reviewed changes
Copy link
Contributor

@ArjunSharda ArjunSharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should update with the newest commits and then commit with the changes you made as I don't think this can be merged as it's outdated.

@fukatani fukatani force-pushed the torch-adaptive-avg-pool-test branch from cb93105 to a4fcc62 Compare June 12, 2022 08:08
@fukatani
Copy link
Contributor Author

@ajsharda17
Thanks! I rebased this PR on latest master.

@ArjunSharda
Copy link
Contributor

@ajsharda17 Thanks! I rebased this PR on latest master.

Thanks!

@TobyRoseman TobyRoseman merged commit f91182e into apple:main Jun 13, 2022
@TobyRoseman
Copy link
Collaborator

Thanks @fukatani for another good pull request.

dncnbuck pushed a commit to dncnbuck/coremltools that referenced this pull request Jul 5, 2022
@fukatani @TobyRoseman @dncnbuck
Add torch AdaptiveAvgPool2d test. (apple#1502)
01983e6 
Co-authored-by: Toby Roseman <troseman@apple.com>
dncnbuck pushed a commit to dncnbuck/coremltools that referenced this pull request Sep 3, 2022
@fukatani @TobyRoseman @dncnbuck
Add torch AdaptiveAvgPool2d test. (apple#1502)
108f5da 
Co-authored-by: Toby Roseman <troseman@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunSharda ArjunSharda ArjunSharda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fukatani @TobyRoseman @ArjunSharda