-
Notifications
You must be signed in to change notification settings - Fork 172
Provides explicit makefile targets for files #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplicity of this. I'm a bit concerned that it's harder to follow/reason about.
Are there specific sections that you think are more difficult to understand? We can add some comments there. I'm not sure what level of familiarity I can expect from folks reading the Makefile, but if the people who expect to maintain it don't understand what's going on then that's probably a good signal that we need more explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madrob I think the changes to make it more clear what binaries are being built helps a lot! Thanks!
I think this might have a problem where somebody running |
@madrob Could they not just run |
What would you update? It looks fine to me, the problem was that I was trying to build stuff and not paying attention to the CI workflows as an example of the correct way to do things. |
@madrob I would change this step make containerization and docs to call |
Do you want It looks like |
@madrob Fair enough, let's hold off on those changes then. |
Pushed a squashed commit with signature. |
This reverts commit f9198d6.
This reverts commit f9198d6.
fixes #165
init
depends onvminitd/bin/vminitd
,vminitd/bin/vmexec
, andbin/cctl
integration
depends onbin/containerization-integration
bin/*
get generated viamake containerization