Implement container prune #904
Open
+203
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tico88612
force-pushed
the
feat/container-prune
branch
2 times, most recently
from
104bdd2 to
589061e
Compare
Contributor
Author
saehejkang
reviewed
Nov 21, 2025
Sources/Services/ContainerAPIService/Containers/ContainersService.swift
Outdated
Show resolved
Hide resolved
Contributor
|
This is also missing integration tests. Again, here is a good PR you can use to help make those. |
tico88612
force-pushed
the
feat/container-prune
branch
from
589061e to
46d4018
Compare
Contributor
Author
Uh, thanks. I just wonder how to write the testcase. |
tico88612
force-pushed
the
feat/container-prune
branch
5 times, most recently
from
829c989 to
0f959a7
Compare
Contributor
Author
|
Ok, testcases are ready. |
1 task
tico88612
force-pushed
the
feat/container-prune
branch
from
0f959a7 to
d6379bf
Compare
saehejkang
reviewed
Nov 23, 2025
saehejkang
reviewed
Nov 23, 2025
saehejkang
reviewed
Nov 23, 2025
tico88612
force-pushed
the
feat/container-prune
branch
from
d6379bf to
a327ffb
Compare
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
tico88612
force-pushed
the
feat/container-prune
branch
from
a327ffb to
b50f515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixed #892
I'm a new contributor here. If there are any better ways to write it, please let me know.
Part of the function references content from PR #902. This PR will be rebased after that PR is merged.
Testing