Conversation
The doc edit is a good catch and it is worthwhile to get that updated with the new alias. @simone-panico Are you cool with making the doc update in #1217 and then giving @natevw credit with a co-author commit? We can then focus on merging that PR and close this one. |
|
Hey @natevw and @saehejkang, I think we should merge this PR, it was your idea in the first place 😉 I will close my PR |
|
Thanks @simone-panico and appreciate your work on that other issue I filed too! @saehejkang looks like this is the one to review now. |
|
@natevw i think you give add @simone-panico credit as co author for work. :) |
|
iiuc adding co-authorship would entail:
(update: this does seem aligned with GH's documentation on the subject) Happy to do so, if a force push wouldn't inconvenience the maintainers here too badly? |
|
@natevw I'm not really sure for force push tbh prolly john would know it |
Feel free to force push whenever, as it is your feature branch. It is encouraged when you are cleaning up your commit history (rebasing, squashing, fixing commit messages). In this case, you are amending a commit to add someone as a co-author so it warrants a force push. |
re. apple#1213 (and cf. apple#1217) Co-authored-by: Simone <simone.panico@icloud.com>
|
Co-authorship added, looks like it must have worked here in the Github UI above :-) |
Presumed fix for #1213. [
UPDATE: oops — did not see the existing #1217 until later. this is the same code change plus a corresponding doc edit.Co-authorship added to the shared change here in this PR.]Full disclosure: I just did this via the GH web editor, did not set up a build environment or confirm the linter/formatter was happy with my version of the syntax. (My original intent in pulling it up was only to peek into what would be involved so that I could subconsciously mull over it while I psyched myself up to upgrade my machine to Liquid Glass. As it turns out, it didn't look like there was much to mull over!)
Updated the reference guide but I didn't see any related existing tests and as a simple alias seemed like something the command parser library would already have sufficient coverage on.
Type of Change
Motivation and Context
The docker equivalent to listing containers uses the
pscommand. This adds an alias for muscle memory compatibility.Testing