fix: replace unsafe Int32 signal cast with validated Int32(exactly:) in SandboxService kill handler#1221
Open
jay4617 wants to merge 1 commit intoapple:mainfrom
Open
fix: replace unsafe Int32 signal cast with validated Int32(exactly:) in SandboxService kill handler#1221jay4617 wants to merge 1 commit intoapple:mainfrom
jay4617 wants to merge 1 commit intoapple:mainfrom
Conversation
…in SandboxService kill handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
the
kill()handler inSandboxServiceused unsafeInt32()casts to narrow signal values received asInt64overXPC. This could silently truncate out-of-range values, leading to incorrect signals being sent to containers or processes. This fix replaces the unsafe casts with Int32(exactly:), which validates the value fits within range and throws a descriptive .invalidArgument error otherwise, resolving the existingTODOcomment online 486Testing