Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caveat to README #16

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add caveat to README #16

merged 1 commit into from
Aug 7, 2024

Conversation

jeffalder
Copy link
Contributor

In troubleshooting bazelbuild/bazel#23170, I had to dig deep into this code to understand what was happening. Bazel's default error does not apply to this situation, and Bazel's own debugging is also unhelpful. In fact, per the issue, in 7.x, you get java.lang.NullPointerException: Cannot invoke "java.lang.Throwable.getMessage()" because "cause" is null.

I think this change would at least make it easier for folks to identify this issue in their own builds.

In troubleshooting bazelbuild/bazel#23170, I had to dig deep into this code to understand what was happening. Bazel's default error does not apply to this situation, and Bazel's own debugging is also unhelpful. In fact, per the issue, in 7.x, you get `java.lang.NullPointerException: Cannot invoke "java.lang.Throwable.getMessage()" because "cause" is null`.

I think this change would at least make it easier for folks to identify this issue in their own builds.
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! LGTM

@shs96c shs96c merged commit e738774 into apple:main Aug 7, 2024
@jeffalder jeffalder deleted the patch-1 branch August 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants