Skip to content

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Dec 13, 2022

@KazuCocoa KazuCocoa changed the title chorer: remove duplications chore: remove duplicated clean command May 29, 2023
@KazuCocoa KazuCocoa marked this pull request as ready for review May 29, 2023 20:38
@KazuCocoa KazuCocoa merged commit 2f45ef9 into master Jun 8, 2023
@KazuCocoa KazuCocoa deleted the remove-duplications branch June 8, 2023 06:53
@mykola-mokhnach
Copy link
Contributor

@KazuCocoa I think I know the reason why this override has been present there: https://discuss.appium.io/t/clear-is-not-working-anymore-what-is-the-alternative/39421/5

The original API in selenium returns None while the overridden one returns the self instance, so chaining could be possible

@KazuCocoa
Copy link
Member Author

oh, i see. Then, let me rever this change and leave it as a comment

KazuCocoa added a commit that referenced this pull request Jun 13, 2023
KazuCocoa added a commit that referenced this pull request Jun 13, 2023
* Revert "chore: remove duplicated clean command (#809)"

This reverts commit 2f45ef9.

* chore: left a comment

* trim spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants