Skip to content

Conversation

mykola-mokhnach
Copy link
Contributor

No description provided.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should value in test code revert?
appium/webdriver/webdriver.py looks good.

@mykola-mokhnach
Copy link
Contributor Author

Should value in test code revert?
appium/webdriver/webdriver.py looks good.

I have both cases now in tests

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay.
I'd prefer to keep value in test_helper.py (not webdriver_test.py) to keep the current appium 2.0 response as mocks, but no issues are there.

@mykola-mokhnach mykola-mokhnach merged commit 22dfeca into appium:master Jun 17, 2022
@mykola-mokhnach mykola-mokhnach deleted the resp_check branch June 17, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants