chore: Add table for screen_record kwarg #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| +--------------+-----+---------+-----+-------+ | ||
| | Keyword Args | iOS | Android | Win | macOS | | ||
| +==============+=====+=========+=====+=======+ | ||
| | remotePath | O | O | O | O | |
There was a problem hiding this comment.
some of these args belong to stop_recording method
| +--------------+-----+---------+-----+-------+ | ||
| | videoFps | O | | | | | ||
| +--------------+-----+---------+-----+-------+ | ||
| | videoFilter | O | | O | O | |
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah, videoFilter should be the correct one. sorry for the confusion: https://github.com/appium/appium-mac2-driver/blob/ff143194b199ae08803bce7adc7a51793c810491/lib/commands/record-screen.js#L235
ki4070ma
changed the title
mykola-mokhnach
approved these changes
Feb 10, 2021
| +--------------+-----+---------+-----+-------+ | ||
| | timeLimit | O | O | O | O | | ||
| +--------------+-----+---------+-----+-------+ | ||
| | user | O | O | O | O | |
There was a problem hiding this comment.
user entry is duplicated
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#580 (comment)
Note
http://appium.io/docs/en/commands/device/recording-screen/start-recording-screen/
http://appium.io/docs/en/commands/device/recording-screen/stop-recording-screen/
https://github.com/appium/appium-windows-driver/blob/master/lib/commands/record-screen.js
https://github.com/appium/appium-mac2-driver/blob/master/lib/commands/record-screen.js
https://github.com/appium/appium-android-driver/blob/master/lib/commands/recordscreen.js
https://github.com/appium/appium-xcuitest-driver/blob/master/lib/commands/recordscreen.js
Test