chore: Update pipfile to respect isort v5 #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ki4070ma
changed the title
ki4070ma
commented
Feb 6, 2021
| [packages] | ||
| selenium = "~=3.141" | ||
|
|
||
| black = "==20.8b1" |
There was a problem hiding this comment.
(note) black = "~=20.8b1" doesn't work.
|
|
||
| [dev-packages] | ||
| pre-commit = "~=2.6" | ||
| pre-commit = "~=2.10" |
There was a problem hiding this comment.
could dependabot do that?
There was a problem hiding this comment.
Yes.
I don't remember the reason to stop using it now, but previously we used it.
Can we use it again? > @KazuCocoa
mykola-mokhnach
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since isort v4 is used.
Note
Currently mypy target is only
functionalundertest.(test/unitis ignored by mypy v0.782 somehow.)(But in my opinion, it isn't so impact even if
test/unitis not target.)