-
Notifications
You must be signed in to change notification settings - Fork 572
feat: Added Makefile #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Makefile #530
Conversation
return session['events'] | ||
except Exception as e: | ||
logger.warning('Could not find events information in the session. Error:', e) | ||
logger.warning('Could not find events information in the session. Error: %s', e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Notes] Fixed pylint error
( | ||
LINT_RESULT=$(python -m pylint --rcfile .pylintrc appium test --errors-only 2>&1 | tee /dev/tty) | ||
if [[ $? -ne 0 ]] ; then | ||
EXIT_STATUS=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Notes] This EXIT_STATUS
scope is within subshell (()
).
@@ -0,0 +1,25 @@ | |||
.PHONY: Commands for developers | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding all
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, added check-all
command.
Changes
help
command: https://marmelab.com/blog/2016/02/29/auto-documented-makefile.html