Skip to content

Conversation

ki4070ma
Copy link
Collaborator

@ki4070ma ki4070ma commented May 5, 2020

Changes

  1. Added setup.cfg
  2. Added Makefile ( Add Makefile for developers #523 )
  3. Fix ci.sh to set failure even when one command failed

@ki4070ma ki4070ma changed the title [WIP] Added setup.cfg Added Makefile May 5, 2020
@ki4070ma ki4070ma marked this pull request as ready for review May 5, 2020 05:15
return session['events']
except Exception as e:
logger.warning('Could not find events information in the session. Error:', e)
logger.warning('Could not find events information in the session. Error: %s', e)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Notes] Fixed pylint error

(
LINT_RESULT=$(python -m pylint --rcfile .pylintrc appium test --errors-only 2>&1 | tee /dev/tty)
if [[ $? -ne 0 ]] ; then
EXIT_STATUS=1
Copy link
Collaborator Author

@ki4070ma ki4070ma May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Notes] This EXIT_STATUS scope is within subshell (()).

@ki4070ma ki4070ma changed the title Added Makefile feat: Added Makefile May 5, 2020
@@ -0,0 +1,25 @@
.PHONY: Commands for developers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding all?

Copy link
Collaborator Author

@ki4070ma ki4070ma May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added check-all command.

@ki4070ma ki4070ma merged commit 0abc021 into appium:master May 5, 2020
@ki4070ma ki4070ma deleted the setup-cfg branch May 5, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants