Skip to content

chore: Fix int - str comparison error in ios desired capabilities #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2020
Merged

chore: Fix int - str comparison error in ios desired capabilities #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,18 @@ $ pytest -n 2 test/unit
### Functional

```
$ pytest test/functional/ios/find_by_ios_class_chain_tests.py
$ pytest test/functional/ios/search_context/find_by_ios_class_chain_tests.py
```

### In parallel for iOS
1. Create simulators named 'iPhone 6s - 8100' and 'iPhone 6s - 8101'
1. Create simulators named 'iPhone 8 - 8100' and 'iPhone 8 - 8101'
2. Install test libraries via pip
```
$ pip install pytest pytest-xdist
```
3. Run tests
```
$ pytest -n 2 test/functional/ios/find_by_ios_class_chain_tests.py
$ pytest -n 2 test/functional/ios/search_context/find_by_ios_class_chain_tests.py
```

# Release
Expand Down
4 changes: 2 additions & 2 deletions test/functional/ios/helper/desired_capabilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def gw(number):
if PytestXdistWorker.COUNT is None:
return '0'

if number >= PytestXdistWorker.COUNT:
if number >= int(PytestXdistWorker.COUNT):
return 'gw0'

return 'gw{}'.format(number)
Expand All @@ -65,7 +65,7 @@ def wda_port():
return 8100


# Before running tests, you must have iOS simulators named 'iPhone 6s - 8100' and 'iPhone 6s - 8101'
# Before running tests, you must have iOS simulators named 'iPhone 8 - 8100' and 'iPhone 8 - 8101'


def iphone_device_name(port=None):
Expand Down