Skip to content

Update docstring #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 30, 2019
Merged

Update docstring #407

merged 7 commits into from
Jun 30, 2019

Conversation

ki4070ma
Copy link
Collaborator

@ki4070ma ki4070ma commented Jun 25, 2019 •
edited
Loading

Changes

  • Add full links to WebDriver, WebElement in docstring
    • To make more detailed links on docstring (e.g. To enable jumping to declaration from docstring in pycharm)
  • Update some docstring to Google style
  • Resolve import error on pycharm
  • (No production code changes)

Notice

Basically type hinting works on pycharm even in Google style for docstring.
However type hinting doesn't work in webdriver.py somehow. (So #404 change is still necessary for now.)

@ki4070ma ki4070ma added the WIP label Jun 25, 2019
@ki4070ma ki4070ma removed the WIP label Jun 29, 2019
ki4070ma
ki4070ma commented Jun 30, 2019
View reviewed changes
@ki4070ma ki4070ma merged commit 2cfcf09 into appium:master Jun 30, 2019
@ki4070ma ki4070ma deleted the add-type-hinting branch June 30, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ki4070ma @KazuCocoa