Skip to content

Conversation

VinayakaMayura
Copy link
Contributor

@VinayakaMayura VinayakaMayura commented Jun 13, 2019

Change list

Move reset(self) method from webdriver.py to applications.py

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

This is in reference to #325 . Moved the reset app method from Webdriver.py to applications.py

Already test is added for this method in app_test.py

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are out of this code. We should make them stable

@KazuCocoa KazuCocoa merged commit b644712 into appium:master Jun 13, 2019
@ki4070ma
Copy link
Collaborator

[Just memo] Although I re-ran CI and log was gone, this error is due to azure pipeline(like 'error occurs
due to disconnection with host'), I would say. So we can't do anything for that error in my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants