Assign w3c property on the command executor. #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures should be green by #383 |
|
@KazuCocoa When are you likely to release these changes when they get merged in? I'm not familiar with your release schedule. |
|
We have no regular release cycle. Just fixing bugs, adding new features, then I run release script. |
|
Ok thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call
start_session()on the webdriver we assign the w3c capabilities on the driver but not on the command_executor which then means that when we execute a command we do not remove the sessionId from the request which regresses from this change SeleniumHQ/selenium@e6c2e70.