ci: moving to GHA #1010
Merged
ci: moving to GHA #1010
+28
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 228fe8a.
| @@ -65,10 +65,10 @@ jobs: | |||
| appium plugin install execute-driver | |||
| nohup appium --use-plugins=images,execute-driver --relaxed-security --log-timestamp --log-no-colors > appium.log & | |||
|
|
|||
| - name: Set up Python 3.9 | |||
| - name: Set up Python 3.12 | |||
There was a problem hiding this comment.
does this plugin allow to just set the version to "latest"?
There was a problem hiding this comment.
Unfortunately, it looks like no. I tried the latest once but may have failed at that time. After removing the version, I installed v3.8.
mykola-mokhnach
approved these changes
Aug 1, 2024
| try: | ||
| self.driver.set_network_connection(ConnectionType.DATA_ONLY) | ||
| except Exception: | ||
| assert False, "Should not raise any exceptions" |
There was a problem hiding this comment.
you could also use pytest.fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove Azure completely