Skip to content

test: Align Selenium version in test dependencies #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valfirst merged 1 commit into from
Oct 13, 2023
Merged

test: Align Selenium version in test dependencies #2042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ dependencies {
testImplementation (group: 'io.github.bonigarcia', name: 'webdrivermanager', version: '5.5.3') {
exclude group: 'org.seleniumhq.selenium'
}
testImplementation platform(group: 'org.seleniumhq.selenium', name: 'selenium-bom', version: '4.13.0')
testImplementation platform(group: 'org.seleniumhq.selenium', name: 'selenium-bom', version: '4.14.1')
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we cannot use ${seleniumVersion} template there?

Copy link
Collaborator Author

@valfirst valfirst Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it doesn't matter which form of version to put, because we stick to the latest version (4.14.1) everywhere. But once new version of Selenium is released, @dependabot will pick it up and open PR with update of the version in test dependencies. In this way CI tests will be run against the latest Selenium client, if any compatibility issue appear, we'll detect it immediately.

Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this time there was no PR from dependabot?

Copy link
Collaborator Author

@valfirst valfirst Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@depenabot is run by schedule (https://github.com/appium/java-client/blob/master/.github/dependabot.yml#L3-L8): once a week (on Monday) for this repo. Or it can be triggered manually.

Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume triggering it manually would still save more time in comparison to a custom PR creation

testImplementation 'org.seleniumhq.selenium:selenium-api'
testImplementation 'org.seleniumhq.selenium:selenium-remote-driver'
testImplementation 'org.seleniumhq.selenium:selenium-support'
Expand Down