Skip to content

fix: Change scope of selenium-support dependency to compile #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

valfirst
Copy link
Collaborator

Change list

Fixes #2012.

AppiumFluentWait (which is a part of Appium Java Client API) extends FluentWait from selenium-support dependency, thus this dependency must be in compile classpath.

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation:

Dependencies appearing in the api configurations will be transitively exposed to consumers of the library, and as such will appear on the compile classpath of consumers. Dependencies found in the implementation configuration will, on the other hand, not be exposed to consumers, and therefore not leak into the consumers' compile classpath.

@valfirst valfirst merged commit 4e3b23b into appium:master Sep 20, 2023
@valfirst valfirst deleted the fix-change-scope-of-selenium-support-dependency-to-compile branch September 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants