Skip to content

chore: switch to javac compiler #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2021
Merged

chore: switch to javac compiler #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7617980
chore: switch to javac compiler
mykola-mokhnach Oct 27, 2021
65e5c09
Make compiler happy
mykola-mokhnach Oct 27, 2021
11a3463
Restore Eclipse plugin
mykola-mokhnach Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import org.apache.tools.ant.filters.*
plugins {
id 'java-library'
id 'idea'
id 'maven-publish'
id 'eclipse'
id 'maven-publish'
id 'jacoco'
id 'checkstyle'
id 'signing'
Expand All @@ -16,42 +16,17 @@ repositories {
mavenCentral()
}

configurations {
ecj
lombok
}

dependencies {
ecj 'org.eclipse.jdt:ecj:3.26.0'
lombok 'org.projectlombok:lombok:1.18.22'
}

java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
withJavadocJar()
withSourcesJar()
}

compileJava {
def ecjJar = configurations.ecj.singleFile
def lombokjar = configurations.lombok.singleFile

options.fork = true
options.fork executable: 'java', jvmArgs: [ '-javaagent:'+lombokjar.path+'=ECJ', '-jar', ecjJar.path, '-cp', lombokjar.path]
options.define compilerArgs: [
'-encoding', 'utf-8',
// https://www.ibm.com/support/knowledgecenter/SS8PJ7_9.7.0/org.eclipse.jdt.doc.user/tasks/task-using_batch_compiler.htm
'-warn:-unused,-unchecked,-raw,-serial,-suppress',
]

// https://github.com/gradle/gradle/issues/12904
options.headerOutputDirectory.convention(null)
}

dependencies {
compileOnly('org.projectlombok:lombok:1.18.22')
annotationProcessor('org.projectlombok:lombok:1.18.20')
compileOnly 'org.projectlombok:lombok:1.18.22'
annotationProcessor 'org.projectlombok:lombok:1.18.22'

api ("org.seleniumhq.selenium:selenium-java") {
version {
strictly "${project.property('selenium.version')}"
Expand Down
23 changes: 1 addition & 22 deletions docs/Note-for-developers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,28 +12,7 @@ This is the Gradle project.

Be sure that:

- The `JAVA_HOME` environmental contains a path to JDK > 7

- If non built-in gradle distribution is used then its version should be > 2.1

## Compiler

This project is compiled in some not common way. We use `ecj` Eclipse Java Compiler. Below is the sample how to define this compiler by IDE.
![eclipse compiler](https://cloud.githubusercontent.com/assets/4927589/14228367/6fce184e-f91b-11e5-837c-2673446d24ea.png)

## JDK

Please check following settings:

![](https://cloud.githubusercontent.com/assets/4927589/18324490/7ffd3ba4-7545-11e6-9f22-eb028737283c.png)

![](https://cloud.githubusercontent.com/assets/4927589/18324593/f5254e3a-7545-11e6-85c5-e4c491ee268d.png)

![](https://cloud.githubusercontent.com/assets/4927589/18324648/3f4635a6-7546-11e6-966c-2949059968ac.png)

![](https://cloud.githubusercontent.com/assets/4927589/18324760/cbca4aee-7546-11e6-8cfb-e86d8018be6a.png)

![](https://cloud.githubusercontent.com/assets/4927589/18324835/2e3bfc04-7547-11e6-8f5e-981aea8f1771.png)
- The `JAVA_HOME` environmental contains a path to JDK 1.8+

## Coding Standards

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/appium/java_client/remote/AppiumCommandExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ private Response createSession(Command command) throws IOException {
}

public void refreshAdditionalCommands() {
getAdditionalCommands().forEach(super::defineCommand);
getAdditionalCommands().forEach(this::defineCommand);
}

@Override
Expand Down