-
-
Notifications
You must be signed in to change notification settings - Fork 768
chore: Add WDA-related XCUITestOptions #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mykola-mokhnach
merged 2 commits into
appium:master
from
mykola-mokhnach:xcuitest_options_2
Oct 26, 2021
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
src/main/java/io/appium/java_client/ios/options/wda/Keychain.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.java_client.ios.options.wda; | ||
|
||
import lombok.Data; | ||
import lombok.ToString; | ||
|
||
@ToString() | ||
@Data() | ||
public class Keychain { | ||
private final String path; | ||
private final String password; | ||
} |
56 changes: 56 additions & 0 deletions
56
src/main/java/io/appium/java_client/ios/options/wda/ProcessArguments.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.java_client.ios.options.wda; | ||
|
||
import lombok.ToString; | ||
|
||
import java.util.Collections; | ||
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Optional; | ||
|
||
@ToString() | ||
public class ProcessArguments { | ||
private final List<String> args; | ||
private final Map<String, Object> env; | ||
|
||
public ProcessArguments(List<String> args, Map<String, Object> env) { | ||
this.args = args; | ||
this.env = env; | ||
} | ||
|
||
public ProcessArguments(List<String> args) { | ||
this(args, null); | ||
} | ||
|
||
public ProcessArguments(Map<String, Object> env) { | ||
this(null, env); | ||
} | ||
|
||
/** | ||
* Returns the data object content as a map. | ||
* | ||
* @return Properties as a map. | ||
*/ | ||
public Map<String, Object> toMap() { | ||
Map<String, Object> result = new HashMap<>(); | ||
Optional.ofNullable(args).ifPresent((v) -> result.put("args", v)); | ||
Optional.ofNullable(env).ifPresent((v) -> result.put("env", v)); | ||
return Collections.unmodifiableMap(result); | ||
} | ||
} |
60 changes: 60 additions & 0 deletions
60
...appium/java_client/ios/options/wda/SupportsAllowProvisioningDeviceRegistrationOption.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.java_client.ios.options.wda; | ||
|
||
import io.appium.java_client.remote.options.BaseOptions; | ||
import io.appium.java_client.remote.options.CanSetCapability; | ||
import org.openqa.selenium.Capabilities; | ||
|
||
import java.util.Optional; | ||
|
||
import static io.appium.java_client.internal.CapabilityHelpers.toSafeBoolean; | ||
|
||
public interface SupportsAllowProvisioningDeviceRegistrationOption<T extends BaseOptions<T>> extends | ||
Capabilities, CanSetCapability<T> { | ||
String ALLOW_PROVISIONING_DEVICE_REGISTRATION_OPTION = "allowProvisioningDeviceRegistration"; | ||
|
||
/** | ||
* Allows xcodebuild to register your destination device on the developer portal. | ||
* | ||
* @return self instance for chaining. | ||
*/ | ||
default T allowProvisioningDeviceRegistration() { | ||
return amend(ALLOW_PROVISIONING_DEVICE_REGISTRATION_OPTION, true); | ||
} | ||
|
||
/** | ||
* Allow xcodebuild to register your destination device on the developer portal | ||
* if necessary. Requires a developer account to have been added in Xcode's Accounts | ||
* preference pane. Defaults to false. | ||
* | ||
* @param value Whether to allow xcodebuild to register your destination device on the developer portal. | ||
* @return self instance for chaining. | ||
*/ | ||
default T setAllowProvisioningDeviceRegistration(boolean value) { | ||
return amend(ALLOW_PROVISIONING_DEVICE_REGISTRATION_OPTION, value); | ||
} | ||
|
||
/** | ||
* Get whether to allow xcodebuild to register your destination device on the developer portal. | ||
* | ||
* @return True or false. | ||
*/ | ||
default Optional<Boolean> doesAllowProvisioningDeviceRegistration() { | ||
return Optional.ofNullable(toSafeBoolean(getCapability(ALLOW_PROVISIONING_DEVICE_REGISTRATION_OPTION))); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: parenthesis could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep them for better readability