chore: Start adding UiAutomator2 options #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
reviewed
Oct 24, 2021
src/main/java/io/appium/java_client/android/options/app/SupportsAllowTestPackagesOption.java
Outdated
Show resolved
Hide resolved
...main/java/io/appium/java_client/android/options/app/SupportsAndroidInstallTimeoutOption.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/android/options/app/SupportsAppWaitForLaunchOption.java
Show resolved
Hide resolved
...ppium/java_client/android/options/server/SupportsUiautomator2ServerInstallTimeoutOption.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/internal/CapabilityHelpers.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/remote/options/SupportsNewCommandTimeoutOption.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/remote/options/SupportsOrientationOption.java
Outdated
Show resolved
Hide resolved
valfirst
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
There are MANY of these options and each of them needs to have some basic documentation and a separate mixin interface.
But I assume the general template is set and is clean enough to follow (I hope). Perhaps, someone could help me to create options for other drivers in parallel to speed up the process?
Types of changes