Skip to content

Conversation

titusfortner
Copy link
Contributor

Change list

  • updated mobile capabilities to use w3c compliant prefix appium:

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

This makes java-client compliant with required w3c syntax, which will likely be necessary when users update to Selenium 4.

The tests like startingAndroidAppWithCapabilitiesOnlyTest fail with this PR, but I would consider these more unit tests than user facing changes because no one should be checking the input to Capabilities with the output from the server.

That said, if we have #1319 we could override getCapability to add appium: if we need the inputs to match the outputs.

I also do not know if or how settings might need to be adjusted to ensure compatible versions of things are used.

@titusfortner
Copy link
Contributor Author

(this is draft because I'm not sure how you want the tests handled, and if this should wait for #1319)

* manifest (action: android.intent.action.MAIN , category: android.intent.category.LAUNCHER)
*/
String APP_ACTIVITY = "appActivity";
String APP_ACTIVITY = "appium:appActivity";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to have a separate constant defined for appium:

@mykola-mokhnach
Copy link
Contributor

I think we cannot merge this change yet, because it will break mjsonwp tests. Actually, it's the same reason we don't incorporate the alpha version of selenium 4 lib - users want to have stable releases rather than alpha snapshots.

@titusfortner
Copy link
Contributor Author

titusfortner commented Mar 29, 2020

Nevermind, you are automatically doing what is needed here:

if (APPIUM_CAPABILITIES.contains(key) && !forceMobileJSONWP) {
return APPIUM_PREFIX + key;
}

and I just missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants