Setting API should accept String type#1240
Merged
mykola-mokhnach merged 1 commit intoappium:masterfrom Sep 23, 2019
takeyaqa:settings_by_string
Merged
Setting API should accept String type#1240mykola-mokhnach merged 1 commit intoappium:masterfrom takeyaqa:settings_by_string
mykola-mokhnach merged 1 commit intoappium:masterfrom
takeyaqa:settings_by_string
Conversation
* add overload method setSetting * add test
mykola-mokhnach
approved these changes
Sep 23, 2019
Contributor
mykola-mokhnach
left a comment
mykola-mokhnach
left a comment
There was a problem hiding this comment.
Thanks. I was thinking about adding this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Java-client Setting API
setSetting(Setting, Object)only accepts enumSetting. It's good for type safe. But, when new settings are added on server, user cannot use it until client update. I think this API should be more flexible.I propose that Setting API can also accept String type like capabilities.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub