-
-
Notifications
You must be signed in to change notification settings - Fork 768
Set up CI with Azure Pipelines #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
azure-pipelines.yml
Outdated
steps: | ||
- script: | | ||
npm install -g appium@beta | ||
./gradlew clean build xcuiTest -x test -x signArchives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/gradle?view=vsts like below?
- task: Gradle@2
inputs:
gradleWrapperFile: 'gradlew'
tasks: 'clean build'
options: 'xcuiTest -x test -x signArchives'
According to https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/macos/macos-Readme.md, we probably can use the gradle
task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KazuCocoa Noted. Neat and clear.
56e9ff2
to
14b717d
Compare
BiPredicate<By, Class<? extends WebElement>> filter, | ||
By by, Class<? extends WebElement> clazz) { | ||
AppiumServiceBuilder builder = new AppiumServiceBuilder() | ||
.withAppiumJS(new File("/usr/local/lib/node_modules/appium/build/lib/main.js")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be cross-platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't get you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could find npm root by executing npm root -g
. The second part of the path is always constant and can be added using path joining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup client does the same internally here but not sure why it couldn't find it inside the azure mac host. So i harcoded the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it would be better to put appium.js path calculation to a separate helper method rather than hardcoding it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup will do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like Paths.get(<Path_to_npm_root>, "appium", "build" ,"lib", "main.js")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking why does client doesn't detect globally installed server path automatically when there is nvm in place in a system... I do remember there are some issues related to it.
I would try to perform
in order to fix azure failures if we still want to keep main js path detection helper |
update azure configs add default server path remove iOS from travis format as per azure guidelines format as per azure guidelines format as per azure guidelines Add appium server installation Install specific version of node Add appium server path Execute on appropriate environment Execute on appropriate environment
2f1d5da
to
ed8429e
Compare
@SrinivasanTarget Probably, it makes sense to install nvm and node same way it is done on Travis instead of using the built-in one. |
@mykola-mokhnach Its fixed now. Can you look into it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it much better now. No magic strings anymore.
No description provided.