add custom locator strategy #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It looks like the linter is not very happy |
| * @since Appium 1.9.2 | ||
| */ | ||
| default T findElementByCustom(String selector) { | ||
| return findElement(MobileSelector.IMAGE.toString(), selector); |
Contributor
There was a problem hiding this comment.
Why MobileSelector.IMAGE ?
Member
There was a problem hiding this comment.
Same question why IMAGE ?
Member
Author
There was a problem hiding this comment.
that was a mistake; I changed it to CUSTOM
|
|
||
| public interface FindsByCustom<T extends WebElement> extends FindsByFluentSelector<T> { | ||
| /** | ||
| * Performs the lookup for a single element by sending a selector to a custom element finding |
Contributor
There was a problem hiding this comment.
It might be handy to put a link to some online document here
Member
Author
There was a problem hiding this comment.
How about promises that I will add documentation soon? :-)
| * @since Appium 1.9.2 | ||
| */ | ||
| default List<T> findElementsByCustom(String selector) { | ||
| return findElements(MobileSelector.IMAGE.toString(), selector); |
Member
Author
|
the travis failure is because of some ios webview issue: |
saikrishna321
approved these changes
Oct 18, 2018
Member
Author
|
Docs PR: appium/appium#11544 |
Member
Author
|
doc links added, though of course they will 404 till new docs are published (which should happen before the next java client publish i imagine, so i think it's ok to merge now) |
mykola-mokhnach
approved these changes
Oct 18, 2018
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the locator strategy in the client to go with appium/appium-base-driver#268.
I based this PR on #990 so hopefully it's OK.