Skip to content

chore: add todo comments in AppiumCommand.cs for future reference#938

Merged
KazuCocoa merged 2 commits into
mainfrom
add-comments
May 4, 2025
Merged

chore: add todo comments in AppiumCommand.cs for future reference#938
KazuCocoa merged 2 commits into
mainfrom
add-comments

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

List of changes

Adds comments to replace with extensions, or remove for Appium 3 era. appium/appium#20792

I haven't checked the actual implementation side to see if some of them are already logged to remove, replace, etc. At least most of them should be sufficient to replace with extensions.

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Test fix (non-breaking change that improves test stability or correctness)

Documentation

  • Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@KazuCocoa KazuCocoa requested a review from Dor-bl May 3, 2025 19:26
@github-actions github-actions Bot added the Chore label May 3, 2025
Comment thread src/Appium.Net/Appium/AppiumCommand.cs
Comment thread src/Appium.Net/Appium/AppiumCommand.cs
@KazuCocoa KazuCocoa merged commit 47224dc into main May 4, 2025
3 checks passed
@KazuCocoa KazuCocoa deleted the add-comments branch May 4, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants