Skip to content

fix: Fix Android TouchActionTest + Simplify name in TouchAction class #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 14, 2022
Merged

fix: Fix Android TouchActionTest + Simplify name in TouchAction class #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c4d85a
Target .NET Framework 4.8
Dor-bl Aug 31, 2022
8c39762
test:Fix ClipboardTests
Dor-bl Sep 10, 2022
a18e9ec
Merge branch 'appium:release/5.0.0' into release/5.0.0
Dor-bl Sep 10, 2022
437b313
Update Selenium from 4.0.0 to 4.4.0.
Dor-bl Sep 12, 2022
0b22e59
Removal of GetDomProperty
Dor-bl Sep 12, 2022
425b0b7
Merge branch 'appium:release/5.0.0' into release/5.0.0
Dor-bl Sep 12, 2022
d3f25e4
build(deps): Update Microsoft.NET.Test.Sdk to 17.3.1
Dor-bl Sep 12, 2022
2135133
Merge branch 'release/5.0.0' of https://github.com/Dor-bl/appium-dotn…
Dor-bl Sep 12, 2022
ae436e2
Minor improvement for TouchAction class
Dor-bl Sep 12, 2022
32f1aea
Fix Android TouchActionTest
Dor-bl Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Appium.Net/Appium/MultiAction/TouchAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ private string GetIdForElement(IWebElement el)
{
WebElement WebElement = el as WebElement;
if (WebElement != null)
return (string) typeof(OpenQA.Selenium.WebElement).GetProperty("Id",
return (string)typeof(WebElement).GetProperty("Id",
BindingFlags.NonPublic |
BindingFlags.Instance).GetValue(el, null);

Expand Down
13 changes: 11 additions & 2 deletions test/integration/Android/TouchActionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ public void SimpleTouchActionTestCase()
var number1 = els.Count;

var tap = new TouchAction(_driver);
tap.Tap(els[4], 10, 5, 2).Perform();
tap.Tap(els[4], 8, 5, 2);
tap.Perform();

els = _driver.FindElements(MobileBy.ClassName("android.widget.TextView"));

Expand All @@ -65,6 +66,10 @@ public void SimpleTouchActionTestCase()
[Test]
public void ComplexTouchActionTestCase()
{
AppiumElement ViewsElem = _driver.FindElement(MobileBy.AccessibilityId("Views"));
var tap = new TouchAction(_driver);
tap.Tap(ViewsElem).Wait(200);
tap.Perform();
IList<AppiumElement> els = _driver.FindElements(MobileBy.ClassName("android.widget.TextView"));
var loc1 = els[7].Location;
var target = els[1];
Expand All @@ -78,8 +83,12 @@ public void ComplexTouchActionTestCase()
[Test]
public void SingleMultiActionTestCase()
{
AppiumElement ViewsElem = _driver.FindElement(MobileBy.AccessibilityId("Views"));
var tap = new TouchAction(_driver);
tap.Tap(ViewsElem).Wait(200);
tap.Perform();
IList<AppiumElement> els = _driver.FindElements(MobileBy.ClassName("android.widget.TextView"));
var loc1 = els[7].Location;
var loc1 = els[8].Location;
var target = els[1];
var loc2 = target.Location;

Expand Down