Skip to content

Conversation

@KazuCocoa
Copy link
Member

Change list

Follows https://github.com/appium/appium-dotnet-driver/blob/master/.github/labeler.yml
Added feat prefix since the deps update JSON version from 12 to 13.

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@KazuCocoa KazuCocoa merged commit 74f30fe into master Jun 29, 2022
@KazuCocoa KazuCocoa deleted the dummy-update branch June 29, 2022 07:49
@KazuCocoa
Copy link
Member Author

oh, this was added as https://github.com/appium/appium-dotnet-driver/releases/tag/untagged-041d3a6b28a48c6dc1b8
What can I do to release #500 ?

I don't have any preferences, but just wondered to fix #501 for v4 base (or 5 beta?)

@laolubenson
Copy link
Collaborator

I usually use the dotnet pack. Without the CLI, I recall publishing a GitHub release will either trigger an action or create a tag and provide you a package to publish but I have to double check this.

I can release both of them from tomorrow. Is v4 ready to go? I can do this first.

As for v5, you can either cherry pick the commit or raise the same PR targeting the branch

@KazuCocoa
Copy link
Member Author

Is v4 ready to go?

Yes, i think so. Thank you 🙏

@KazuCocoa KazuCocoa mentioned this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants