Skip to content

Conversation

Redth
Copy link

@Redth Redth commented Jan 11, 2021

Change list

Just like Espresso's DataMatcher, adding support for ViewMatcher as well which appears to be supported in the espresso driver.

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

There is no ViewMatcher doc at all currently, though it seems to be supported in espresso driver, so not sure what C# docs would be helpful here.

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Looking to add support for decorating some android views with automation identifiers that get set in View.setTag(R.id.automation_id, "idvaluehere") and using ViewMatchers to select views based on those values (ie: onView(withTagKey(8675309,is('idvaluehere'))) with a selector such as:

{
  "name" : "withTagKey",
  "args" : [ 
    8675309, 
    { 
      "name" : "is",
      "args" : "idvaluehere"
    }
  ]
}

@KazuCocoa KazuCocoa requested a review from laolubenson January 12, 2021 06:34
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@KazuCocoa KazuCocoa changed the title Add support for Android Espresso's ViewMatcher feat: Add support for Android Espresso's ViewMatcher Jan 12, 2021
@KazuCocoa
Copy link
Member

Could you sign the CLA? @Redth

@Redth
Copy link
Author

Redth commented Jan 12, 2021

@KazuCocoa CLA signed, thanks !

@laolubenson laolubenson merged commit e75c1eb into appium:master Jan 12, 2021
@Redth
Copy link
Author

Redth commented Jan 13, 2021

Any idea when a release might be published with this?

@laolubenson
Copy link
Collaborator

Can trigger a job to release it ASAP. @Redth is it urgent?

@Redth
Copy link
Author

Redth commented Jan 13, 2021

@akinsolb would be helpful for some work around UI Testing infrastructure for MAUI :)

@laolubenson
Copy link
Collaborator

laolubenson commented Jan 14, 2021

@Redth Will trigger the release now. It might take a while for it to appear in nuget due to indexing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants