feat: Add screen video recording support #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Mar 13, 2020
| '-t', `${this._timeLimit}`, | ||
| '-f', 'gdigrab', | ||
| '-framerate', `${this._fps}`, | ||
| '-i', 'desktop', |
There was a problem hiding this comment.
imurchie
approved these changes
Mar 13, 2020
| } | ||
|
|
||
| async _enforceTermination () { | ||
| if (this._process && this.isRunning()) { |
| log.debug(`Starting ${FFMPEG_BINARY}: ${util.quote(fullCmd)}`); | ||
| this._process.on('output', (stdout, stderr) => { | ||
| if (_.trim(stdout || stderr)) { | ||
| log.debug(`[${FFMPEG_BINARY}] ${stdout || stderr}`); |
There was a problem hiding this comment.
If the output has multiple lines, only the first will have the [${FFMPEG_BINARY}] prefix.
There was a problem hiding this comment.
I would say this is fine. There is no need to see this prefix for each log line
lib/commands/record-screen.js
Outdated
| forceRestart = true, | ||
| } = options; | ||
| if (this._screenRecorder) { | ||
| if (this._screenRecorder.isRunning()) { |
There was a problem hiding this comment.
These two can just be
if (this._screenRecorder?.isRunning()) {
// ...
}
this._screenRecorder = null;The last line isn't needed, really, either, since it is set to the new ScreenRecorder() a couple of lines later.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.