Skip to content

fix: Introduce proper overloads for createRemoteDebugger #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mykola-mokhnach merged 1 commit into from
Feb 7, 2026
+13 −6
Merged

fix: Introduce proper overloads for createRemoteDebugger #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,21 @@ import { RemoteDebugger, REMOTE_DEBUGGER_PORT } from './remote-debugger';
import { RemoteDebuggerRealDevice } from './remote-debugger-real-device';
import type { RemoteDebuggerRealDeviceOptions, RemoteDebuggerOptions } from './types';

export function createRemoteDebugger<T extends boolean> (
opts: T extends true ? RemoteDebuggerRealDeviceOptions : RemoteDebuggerOptions,
realDevice: T
): T extends true ? RemoteDebuggerRealDevice : RemoteDebugger {
export function createRemoteDebugger (
opts: RemoteDebuggerRealDeviceOptions,
realDevice: true
): RemoteDebuggerRealDevice;
export function createRemoteDebugger (
opts: RemoteDebuggerOptions,
realDevice: false
): RemoteDebugger;
export function createRemoteDebugger (
opts: RemoteDebuggerRealDeviceOptions | RemoteDebuggerOptions,
realDevice: boolean
): RemoteDebuggerRealDevice | RemoteDebugger {
return realDevice
? new RemoteDebuggerRealDevice(opts as RemoteDebuggerRealDeviceOptions)
// @ts-ignore TS does not understand that
: new RemoteDebugger(opts);
: new RemoteDebugger(opts as RemoteDebuggerOptions);
}

export { RemoteDebugger, RemoteDebuggerRealDevice, REMOTE_DEBUGGER_PORT };
Expand Down
Loading