feat(screenshot): add configurable screenshot directory via SCREENSHOTS_DIR env var #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TS_DIR env var - Support absolute and relative paths (relative resolved from cwd) - Auto-create directory if it doesn't exist - Add dependency injection for testability - Add 15 unit tests covering path resolution and execution - Update README with configuration docs
Replaced `filename` with `filepath` in the success message to display the full file path of the saved screenshot. This provides more clarity to users on where the screenshot is stored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When running this MCP in the scope of an AI Coding Agent, screenshots taken for evaluation pollute
the root folder of the project. This change introduces a configurable directory for screenshots.
Features:
SCREENSHOTS_DIRenvironment variable to specify where screenshots are savedNB: Documentation submodules have been updated as requested by CONTRIBUTING.md
List of things in this PR: