feat: add device action buttons and allow pausing of source refreshing #746
Conversation
|
I just saw this PR, which is somewhat related |
|
thanks for this contribution @JoelWhitney! will take a look soon |
|
@JoelWhitney are you able to merge main so I can review knowing there are no conflicts? |
|
@jlipps looks like it's up to date, I merged main this morning |
| import InspectorStyles from './Inspector.css'; | ||
| import { withTranslation } from '../../util'; | ||
| import { HiOutlineMicrophone, HiOutlineHome } from 'react-icons/hi'; | ||
| import { BiSquare, BiCircle } from 'react-icons/bi'; |
There was a problem hiding this comment.
can we not use icons from ant design, which are already included?
There was a problem hiding this comment.
I was unable find icons in ant design that made sense for some of the Android buttons and the iOS Siri button. I tried to mix/match some ant design icons alongside the react icons and it looked a little odd.
Looking again at ant design...
- There are no options for the iOS.Siri (no microphone), Android.Overview (no square), or Android.Home (no circle).
- There are options for the iOS.Home (house), Android.Back (back arrow, no chevron), and I could probably use the house icon for Android.Home
JoelWhitney
changed the title
|
@jlipps thanks for reviewing. I added some comments above and pushed a commit to address some of the feedback. Let me know if you have suggestions for addressing the icon feedback |
|
@JoelWhitney in that case I'm fine to keep the new icons. thanks! also I tried to merge in main but it looks like there are now more conflicts again, due to merging other PRs. do you mind fixing conflicts and pushing once more? then i'll be able to get this merged and published. |
|
@jlipps everything appears up to date. I fetched upstream and merged, which returned |
|
sorry @JoelWhitney i had the merge button set to 'rebase' instead of 'squash' so it was showing as unrebasable due to conflicts. my fault! |
appium#746) * Add home and Siri button for iOS devices * Add DeviceActions buttons for iOS and Android * Get session details when attaching to session * Revert interval change * Update README.md * Update package-lock.json * Fix lint errors * PR feedback --------- Co-authored-by: Jonathan Lipps <jlipps@gmail.com>
appium#746) * Add home and Siri button for iOS devices * Add DeviceActions buttons for iOS and Android * Get session details when attaching to session * Revert interval change * Update README.md * Update package-lock.json * Fix lint errors * PR feedback --------- Co-authored-by: Jonathan Lipps <jlipps@gmail.com>
Overview
I'm currently utilizing physical devices that are plugged into a Mac mini across the country. Periodically I will need to manually interact with these devices. Currently, this is very cumbersome using Appium inspector because there are no hardware buttons in the GUI and the page source/screenshot is refreshed every time a command is executed. To make device interactions more seamless, I would like to add some hardware buttons to the GUI and provide a way to pause page source refreshing. When coupled with a mjpeg stream, this makes interacting with devices more streamlined.
Changes made
iOS
Android