Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated antd functionality #745

Merged
merged 4 commits into from
Mar 29, 2023
Merged

chore: replace deprecated antd functionality #745

merged 4 commits into from
Mar 29, 2023

Conversation

eglitise
Copy link
Collaborator

This PR replaces some deprecated antd functionality:

  • Tabs.TabPane -> Tabs.items
  • Tooltip.visible -> Tooltip.open
  • Modal.visible -> Modal.open

jlipps
jlipps requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good but if you run npm run test:lint you'll notice that there are some lint errors which need to be fixed before this can be merged. might want to turn eslint on in your editor so you can see these in real time before committing.

@eglitise eglitise requested a review from jlipps March 29, 2023 14:02
@jlipps jlipps merged commit c52844b into appium:main Mar 29, 2023
@eglitise eglitise deleted the antd-deprecations branch March 30, 2023 06:22
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
@eglitise @shiva-guntoju
chore: replace deprecated antd functionality (appium#745)
009c799 
* chore: remove deprecated antd Tabs.TabPane

* chore: remove deprecated antd Tooltip.visible

* chore: remove deprecated antd Modal.visible

* chore: fix eslint errors
laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
@eglitise
chore: replace deprecated antd functionality (appium#745)
aa42a68 
* chore: remove deprecated antd Tabs.TabPane

* chore: remove deprecated antd Tooltip.visible

* chore: remove deprecated antd Modal.visible

* chore: fix eslint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps Awaiting requested review from jlipps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eglitise @jlipps