fix: attach to session tab not making requests #2103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eglitise
requested changes
May 29, 2025
|
@eglitise Thanks for the feedback, I've addressed your comments! |
regan-karlewicz
commented
May 30, 2025
KazuCocoa
pushed a commit
to projectxyzio/appium-inspector
that referenced
this pull request
Jul 15, 2025
* Support making request with apiKey * Pass headers directly * Update attach to session logic * Prettier * Remove comment * Factor out protocol variable * Address feedback * Return false when vendorProperties is falsy to maintain existing behavior * Add missing headers for fetching session info * Run prettier * Allow overrides for vendor properties * Use guard pattern, handle false return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When navigating to the
Attach to Session...tab in the Sessions view, I had noticed that the requests for discovering sessions were not being made when any cloud vendor was set. It appears that the state'sserverfield does not include the server details anymore.Solution
getRunningSessionsheadersin the request if they exist on the vendorshowErrorif session discovery query cannot be made to give user feedback