feat: add support for Appium 3 session retrieval #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Feb 3, 2025
| let identifier = session.id; | ||
| if ('created' in session && !_.isUndefined(session.created)) { | ||
| // For Appium 3+ sessions, replace session ID with timestamp | ||
| identifier = new Date(session.created).toJSON(); |
There was a problem hiding this comment.
not sure if this would work if multiple sessions were created in parallel at the same time
There was a problem hiding this comment.
The timestamp has a milisecond precision, so it's quite unlikely, but even if this does happen, the list would be rendered just fine, as there are no requirements for the identifier to be unique.
There was a problem hiding this comment.
maybe it worth to make an explicit comment about the uniqueness of the identifier
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for retrieving and attaching to existing sessions in Appium 3, which will use the
/appium/sessionsendpoint (see appium/appium#20880). If such sessions are found, they will also have the session ID (shown in their dropdown entry) replaced with the session creation timestamp.Compatibility with Appium 1-2 and Selenium Grid sessions remains unchanged, although all 3 endpoints are now queried in parallel for better performance.