docs: add note about CORS in dev mode #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
KazuCocoa
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1632, I noticed that I was unable to connect to Selenium Grid devices in the Inspector's dev mode, but it worked fine in production mode. The error I got in dev mode seemed to be related to CORS, so I got curious and tried to connect to a regular Appium server with CORS disabled - and I got the same error. Tried again with CORS enabled, and it worked as expected.
As this behavior is not immediately obvious, this PR adds a note in the contributing docs about the requirement to launch Appium with
--allow-corswhen in dev mode.(I'm still unsure what additional configuration is needed for Selenium Grid, though - I launched Appium, Selenium Grid hub, and Selenium Grid node, all with CORS enabled, yet I was still getting the same error...)