-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate from Parcel v1 to Vite #1558
Conversation
Hmm that's odd, I had the tests run just fine previously... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work!
lg overall, I'll do some testing on my local as well tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg overall. Ran them on my local as well. Had the same comments for the path related (to use join
) which is already addressed, although others look good for me.
* chore: migrate from Parcel v1 to Vite * test: move to vitest & update tests * chore: run prettier * chore: address review comments * chore: use split path for all path.join calls * chore: run prettier
The time has finally come. This PR ditches Parcel v1 and migrates to the very latest (!) version of Vite! 🎉
Other changes include:
@import
paths for the.less
styling file (this didn't work in Parcel)index.jsx
(Vite supports this by default)vitest
for unit and integration tests. E2E tests were left as-is, but I don't think they have ever worked anyway.Some explicitly imported dependencies used with Parcel can now also be removed (e.g.
postcss
), but I am trying to keep this PR as small as possible, so that will come in a separate PR. It will also include the removal ofmocha
/chai
and E2E tests being commented out, to be rebuilt in the future.Basic functionality was tested on both macOS and Windows for:
One unexpected benefit from this migration is that the app seems to open notably faster as well!
Closes #1453.