Skip to content

chore: adjust entrypoint files and their styles #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

eglitise
Copy link
Collaborator

This PR has a few changes for the HTML entrypoint files and their imported style files:

  • Move entrypoint files back to common directory (partial revert of chore: separate web and Electron-specific code #1514)
    • After more investigation into Vite, it made more sense to use the common directory as the root folder, and having the entrypoint file be outside the root was causing issues
  • Adjust the title to 'Appium Inspector'
  • Change the splash window's .less file to .css
    • The splash window does not use any antd-specific CSS, so there is no need to import it. This slightly reduces the bundle size, and allows to skip the less->css translation process during build (for this file only)
  • Merge app.global.less and common.global.less into main.less

As usual, both the browser and Electron builds were tested to work fine.

@github-actions github-actions bot added the chore Internal changes not visible to the user label Jul 16, 2024
@eglitise eglitise merged commit 5a35c8e into appium:main Jul 16, 2024
7 checks passed
@eglitise eglitise deleted the adjust-entrypoints branch July 16, 2024 12:11
laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal changes not visible to the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants