ci: update electron-builder and Azure pipeline configurations #1404
Conversation
nsis-web target is not used
| @@ -21,9 +21,9 @@ jobs: | |||
| steps: | |||
| - checkout: self | |||
| persistCredentials: true | |||
| - task: NodeTool@0 | |||
| - task: UseNode@1 | |||
There was a problem hiding this comment.
consider using lts node version alias instead of the hardcoded one
There was a problem hiding this comment.
I'm not sure if Azure supports the lts value. The documentation only refers to semver values.
There was a problem hiding this comment.
Oh, I forgot it's Azure. Perhaps it makes sense to migrate to GitHub CI
There was a problem hiding this comment.
I agree that GitHub CI would be more convenient, though I'm guessing there was a reason why Azure was originally selected. Maybe the machines are more powerful? It's also used in other Appium projects (e.g. xcuitest driver).
There was a problem hiding this comment.
it was selected before github had any CI. Yes, it is still used, although not by xcuitest driver. It's used in webdriveragent because of the high amount of e2e tests we run there and the limited capability of free macOS-based runners on Github. Otherwise I would also migrate them.
There was a problem hiding this comment.
Perhaps I tried to convert this project to GHA before. Then, I needed maybe Window's signature which probably needed Dan's help. We could restart migrating them.
…#1404) * ci: update azure VM images * ci: update Node for Azure * ci: always publish in x64 and arm64 * ci: move electron-builder config into own file for clarity * ci: remove electron-builder nsisWeb option nsis-web target is not used * ci: slightly adjust common package options * ci: remove electron-build filepaths already included by default * ci: use common artifact name format * ci: omit repeating default paths to app icon * ci: build separate artifacts for both mac architectures * ci: add tar.gz target for Linux * ci: add entitlements file for mac signing * chore: fix syntax for Azure UseNode task
This PR updates the configuration for
electron-builder(which generates OS-specific application packages) and the Azure pipeline that is triggered during the release process (which is whereelectron-builderis run):electron-builderconfig to a separate file for clarityx86_64suffix instead ofx64tar.gzartifacts for LinuxAs a result of these changes, I believe the number of generated artifacts will now increase to 26.
Resolves #1400.