Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add pcloudy:options for setting the 'source', username and apikey capability for pCloudy to comply with W3C #1388

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: add pcloudy:options for setting the 'source', username and apikey capability for pCloudy to comply with W3C #1388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1289b07
fix: add pcloudy:options for setting the 'source', username and apike…
shibupanda Mar 13, 2024
0dae356
fix: formatting error
shibupanda Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions app/renderer/actions/Session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,17 +402,17 @@ export function newSession(caps, attachSessId = null) {
host = session.server.pcloudy.hostname;
port = session.server.pcloudy.port = 443;
path = session.server.pcloudy.path = '/objectspy/wd/hub';
desiredCapabilities.pCloudy_Username =
session.server.pcloudy.username || process.env.PCLOUDY_USERNAME;
desiredCapabilities.pCloudy_ApiKey =
session.server.pcloudy.accessKey || process.env.PCLOUDY_ACCESS_KEY;
if (
!(session.server.pcloudy.username || process.env.PCLOUDY_USERNAME) ||
!(session.server.pcloudy.accessKey || process.env.PCLOUDY_ACCESS_KEY)
) {
showError(new Error('PCLOUDY username and api key are required!'));
username = session.server.pcloudy.username || process.env.PCLOUDY_USERNAME;
accessKey = session.server.pcloudy.accessKey || process.env.PCLOUDY_ACCESS_KEY;
if (!username || !accessKey) {
showError(new Error(i18n.t('pcloudyCredentialsRequired')));
return false;
}
desiredCapabilities['pcloudy:options'] = {
source: 'appiumdesktop',
pCloudy_Username: username,
pCloudy_ApiKey: accessKey,
};
https = session.server.pcloudy.ssl = true;
break;
case ServerTypes.testingbot:
Expand Down
Loading